Update setup script for Python 3.7 #9605
Conversation
|
Note that the appveyor build failure is expected. |
|
A clarification on Nevertheless, the wheels are compiled and published in real time after each commit, and you will find them in the py2exe Bintray. These wheels are always updated, hence the 0.9.3.1 version number, and right now they include your PR about .ico files. Feel free to download and install them to test directly the effects of your changes on NVDA. When it is ready, the final release of 0.3.9.1 will be frozen and published on GitHub (and, in the future, on PyPI). As you can imagine, commits that will come after the release will be compiled and published on Bintray under the next version name (presumably 0.9.3.2). |
There was a problem hiding this comment.
Looks really good.
You may want to consider changing the template sintax for the manifest to use Python format syntax I.e.
{UIA}
rather than
%(UIA)s
and obviously then change
manifest_template%dict(UIAccess=target['UIAccess'])
to
manifest_template.format(UIAccess=target['UIAccess'])
|
_i tried what you suggested, but that breaks on the several GUIDs that are in the manifest and that are treated as keys in Python's formatting syntax.
|
|
Fair enough. Don't worry about it then.
I'm happy to approve this. Are you ready for me to merge this to
threshold in that case?
|
|
I'd like to test drive this another time in order to make sure that the
recent changes regarding importlib behave as they should.
Furthermore, note that merging this will instantly break threshold
snapshots. I think we should consider this carefully. It is expected
that there will be some time in which threshold isn't going to build.
However, I'd vote for having at least all the major external
dependencies in shape (#9630), have scons in a basic state in which it
can build all the necessities, and at least have syntax compatibility
with python 3.
|
|
Apologies, I was thinking of the wrong pr. My mistake. Ignore that last
comment :) I was thinking of the one that removes deprecated things.
|
|
I squashed this all in one commit for ease of testing |
|
This is still marked as draft. As dependencies are now updated in threshold_py3_staging, is this ready to be reviewed? |
|
Yes, thanks for remindingb. |
Link to issue number:
Fixes #8375
Closes #9604
Summary of the issue:
For the Python 2 distribution of NVDA< we're using py2exe 0.6, which is compatible with NVDA. For the Python 3 migration/transition, we decided to go with the py2exe fork by @albertosottile.
Description of how this pull request fixes the issue:
This pr converts the setup script to be compatible with py2exe>0.9.3.1. In short, the following had to be changed:
Testing performed:
The command to run py2exe on my system looked as follows:
c:\python37\python.exe setup.py build --build-base ..\build py2exe --dist-dir ..\distKnown issues with pull request:
This relies on several things to be done first:
Change log entry:
t.b.d.